From 252afc9aa22d922fed7caa5c7c39ce2e8d9d7927 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?IOhannes=20m=20zm=C3=B6lnig?=
 <zmoelnig@users.sourceforge.net>
Date: Fri, 4 Sep 2015 20:25:36 +0000
Subject: resolve hostname before opening a socket.

so we can do an early return, without having to care about closing
sockets...
CID:27769

also fix comments (we don't have a "command line")


svn path=/trunk/externals/iem/iemnet/; revision=17550
---
 tcpsend.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/tcpsend.c b/tcpsend.c
index 4597a32..aa0f7e1 100644
--- a/tcpsend.c
+++ b/tcpsend.c
@@ -69,6 +69,14 @@ static void tcpsend_connect(t_tcpsend *x, t_symbol *hostname,
     return;
   }
 
+  /* resolve hostname provided as argument */
+  server.sin_family = AF_INET;
+  hp = gethostbyname(hostname->s_name);
+  if (hp == 0) {
+    iemnet_log(x, IEMNET_ERROR, "bad host '%s'?", hostname->s_name);
+    return;
+  }
+
   /* create a socket */
   sockfd = socket(AF_INET, SOCK_STREAM, 0);
   DEBUG("send socket %d\n", sockfd);
@@ -77,13 +85,7 @@ static void tcpsend_connect(t_tcpsend *x, t_symbol *hostname,
     sys_sockerror("socket");
     return;
   }
-  /* connect socket using hostname provided in command line */
-  server.sin_family = AF_INET;
-  hp = gethostbyname(hostname->s_name);
-  if (hp == 0) {
-    iemnet_log(x, IEMNET_ERROR, "bad host '%s'?", hostname->s_name);
-    return;
-  }
+
   /* for stream (TCP) sockets, specify "nodelay" */
   intarg = 1;
   if (setsockopt(sockfd, IPPROTO_TCP, TCP_NODELAY,
@@ -92,6 +94,7 @@ static void tcpsend_connect(t_tcpsend *x, t_symbol *hostname,
     sys_sockerror("setsockopt");
   }
 
+  /* connect socket using hostname provided as argument */
   memcpy((char *)&server.sin_addr, (char *)hp->h_addr, hp->h_length);
 
   /* assign client port number */
-- 
cgit v1.2.1