|
When I first starting looking into different ways to stream audio into Pd, I
spent a little bit of time looking at streamin~/streamout~. While looking at
it, I fixed the security issue from the previous commit, and made the following
updates to stream.h.
- Adding doxygen style comments.
- Add an ifdef to prevent against multiple or recursive includes of the header.
- Document most of the fields in the defined data structures.
- Fix potential alignment bugs (at least on platforms using GNUC) by using the
packed attribute for structures defining network frames.
See http://gcc.gnu.org/onlinedocs/gcc-4.2.2/gcc/Variable-Attributes.html#Variable%20Attributes
- Point out the fact that this code is not endianness-safe, and that it should
eventually be updated to respect network byte order.
- Point out that the version field of the frame header is ignored when parsing
incoming frames.
- Change a list of #defines to an enum.
- Instead of using "int" in the frame header structure, use int32_t to explicitly
state that the field is 32-bits.
svn path=/trunk/externals/ggee/; revision=9134
|
