From 333f803b4d80a3da30a7678328c0c51890bc4c53 Mon Sep 17 00:00:00 2001 From: Russell Bryant Date: Thu, 10 Jan 2008 03:55:28 +0000 Subject: (from issue #1836228) This little patch slightly improves pd_makeversion(). Namely, I didn't like the use of sprintf() which ignored the possibility of the version string being longer than the allowed buffer size. Also, I changed malloc+strcpy to the slightly simpler strdup(). svn path=/trunk/; revision=9145 --- .../patches/buildversion_tweak-0.41.0-test10.patch | 23 ++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 packages/patches/buildversion_tweak-0.41.0-test10.patch diff --git a/packages/patches/buildversion_tweak-0.41.0-test10.patch b/packages/patches/buildversion_tweak-0.41.0-test10.patch new file mode 100644 index 00000000..7868269b --- /dev/null +++ b/packages/patches/buildversion_tweak-0.41.0-test10.patch @@ -0,0 +1,23 @@ +Index: s_main.c +=================================================================== +RCS file: /cvsroot/pure-data/pd/src/s_main.c,v +retrieving revision 1.28.6.6 +diff -u -r1.28.6.6 s_main.c +--- s_main.c 6 Jan 2008 04:19:15 -0000 1.28.6.6 ++++ s_main.c 6 Jan 2008 04:29:01 -0000 +@@ -249,10 +249,11 @@ + static void pd_makeversion(void) + { + char foo[100]; +- sprintf(foo, "Pd version %d.%d-%d%s\n",PD_MAJOR_VERSION, +- PD_MINOR_VERSION,PD_BUGFIX_VERSION,PD_TEST_VERSION); +- pd_version = malloc(strlen(foo)+1); +- strcpy(pd_version, foo); ++ ++ snprintf(foo, sizeof(foo), "Pd version %d.%d-%d%s\n", PD_MAJOR_VERSION, ++ PD_MINOR_VERSION, PD_BUGFIX_VERSION, PD_TEST_VERSION); ++ ++ pd_version = strdup(foo); + } + + /* this is called from main() in s_entry.c */ -- cgit v1.2.1